Fix occasional "failed to acquire scoreboard" warning #9019
Conversation
|
Not sure if we should completely remove the info. cc @bukka |
|
@Nilix007 Do you see a lot of those? I think if this is happening a lot, then it can't degrade the functionality of slowlog - not logging all slow requests. We might need to look into improving the scoreboard locking in such case. I agree that warning is not the right level if you can't do anything about this. However it might still be quite useful to now if slowlog might potentially miss some items. So I would suggest to just lower the log level and instead use |
About twice a day, so not too often.
Sure, I'll update the PR 👍 |
With request timeouts configured, php-fpm occasionally prints the following warning: WARNING: failed to acquire scoreboard This is happens when php-fpm checks the child scoreboards for timeouts, but fails to acquire a lock immediately. As this can (and does) occur during normal operation, this commit downgrades this to a notice.
Nilix007
force-pushed
the
fix_failed_to_acquire_scoreboard_warning
branch
from
ef75955 to
e90a564
Compare
|
Thank you ! |
|
I'm not sure we should be merging that to 8.0 because this is not really a bug and there is minor chance that some tools are configured to deal with specific messages from logs even though it's a small chance we still shouldn't do that. @devnexen Please could you revert this from 8.0 and 8.1 and keep it only in master? |
|
Sorry my mistake, reverted. |
With request timeouts configured, php-fpm occasionally prints the
following warning:
This is happens when php-fpm checks the child scoreboards for timeouts,
but fails to acquire a lock immediately. As this can (and does) occur
during normal operation, this commit simply removes the warning
altogether.